Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base): new preview components using Sanity UI #2749

Merged
merged 7 commits into from
Sep 10, 2021
Merged

feat(base): new preview components using Sanity UI #2749

merged 7 commits into from
Sep 10, 2021

Conversation

sjelfull
Copy link
Member

@sjelfull sjelfull commented Sep 7, 2021 •
edited

Description

This migrates all remaining preview components except DefaultPreview to Sanity UI.

What to review

Review that the previews look and behaves as expected.

Links to documents where the different previews are used:

  • BlockPreview
  • BlockImagePreview
  • DetailPreview - select Detailed view in top right context menu
  • InlinePreview (TODO - forgot where this was used)
  • MediaPreview - this one includes a progress circle that shows if you drag and uploads an image directly onto it. The progress circle has also been ported, so make sure you test it and review if styling and animations looks alright.

Below is screenshots before and after migration to help make the review easier:

BlockPreview

image

BlockImagePreview

image

MediaPreview

image

DetailPreview

image

InlinePreview

image

Notes for release

  • Migrated all remaining preview components to Sanity UI

@sjelfull sjelfull self-assigned this Sep 7, 2021
@vercel
Copy link

vercel bot commented Sep 7, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/CaCRzjLdobbouLZ9mqo24vTcxDyk
✅ Preview: https://perf-studio-git-feat-ch1673new-preview-components-using-3136fd.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/34pHYryEdXARAj2F1CSkwvwpNRDR
✅ Preview: https://test-studio-git-feat-ch1673new-preview-components-using-37f49f.sanity.build

@sjelfull sjelfull force-pushed the feat/ch1673/new-preview-components-using-sanity-ui branch from 7cd9159 to 6baf242 Compare September 7, 2021 13:17
@sjelfull sjelfull force-pushed the feat/ch1673/new-preview-components-using-sanity-ui branch from 7065757 to 8d3f406 Compare September 8, 2021 12:05
@sjelfull sjelfull marked this pull request as ready for review September 8, 2021 12:06
bjoerge
bjoerge approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, left a few comments/questions/suggestions

packages/@sanity/base/src/__legacy/@sanity/components/previews/BlockImagePreview.tsx Outdated Show resolved Hide resolved
packages/@sanity/base/src/components/previews/blockImagePreview.tsx Outdated Show resolved Hide resolved
packages/@sanity/base/src/components/previews/blockImagePreview.tsx Outdated Show resolved Hide resolved
packages/@sanity/base/src/components/previews/blockPreview.tsx Outdated Show resolved Hide resolved
@sjelfull sjelfull force-pushed the feat/ch1673/new-preview-components-using-sanity-ui branch from 22f0f68 to d28aa6a Compare September 10, 2021 09:08
@sjelfull sjelfull force-pushed the feat/ch1673/new-preview-components-using-sanity-ui branch from d28aa6a to 8aa5b04 Compare September 10, 2021 09:12
@sjelfull sjelfull merged commit 3696728 into next Sep 10, 2021
@sjelfull sjelfull deleted the feat/ch1673/new-preview-components-using-sanity-ui branch September 10, 2021 09:27
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
8630812
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
a4f5323
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
5a9d0b7
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
029729b
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
15511f3
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
8585ca5
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
79530e6
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
c98be82
hermanwikner pushed a commit that referenced this pull request Sep 13, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
a61e3dc
hermanwikner pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
6c0e8ea
hermanwikner pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
db1113e
hermanwikner pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
1968624
mariuslundgard pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull @mariuslundgard
feat(base): new preview components using Sanity UI (#2749)
dbac87a
mariuslundgard pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull @mariuslundgard
feat(base): new preview components using Sanity UI (#2749)
a2465f0
mariuslundgard pushed a commit that referenced this pull request Sep 14, 2021
@sjelfull @mariuslundgard
feat(base): new preview components using Sanity UI (#2749)
33ff5c7
hermanwikner pushed a commit that referenced this pull request Sep 21, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
e3a0bfa
hermanwikner pushed a commit that referenced this pull request Sep 21, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
20df2c8
hermanwikner pushed a commit that referenced this pull request Sep 21, 2021
@sjelfull
feat(base): new preview components using Sanity UI (#2749)
68097d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariuslundgard mariuslundgard mariuslundgard approved these changes

@bjoerge bjoerge bjoerge approved these changes

@hermanwikner hermanwikner Awaiting requested review from hermanwikner

@rexxars rexxars Awaiting requested review from rexxars

Assignees

@sjelfull sjelfull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjelfull @mariuslundgard @bjoerge