[form-builder] [schema] Add datetime type with default input #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomax
force-pushed
the
feature/simple-date
branch
from
1c25499
to
f18447d
Compare
bjoerge
force-pushed
the
feature/simple-date
branch
2 times, most recently
from
82cd3ce
to
401f1f1
Compare
|
I think this is ready to ship now.
Side note: in the future we should probably replace react-datepicker with a native |
bjoerge
changed the title
bjoerge
force-pushed
the
feature/simple-date
branch
5 times, most recently
from
4d694ed
to
ccd1500
Compare
|
Good job on the refactoring. Seems date/time is one of those areas where there is no perfect solution, just the least painful one. Hoping or a painless future! |
…/date-input to @sanity/rich-date-input
bjoerge
force-pushed
the
feature/simple-date
branch
from
d541a20
to
95f21eb
Compare
bjoerge
approved these changes
Oct 19, 2017
bjoerge
pushed a commit
that referenced
this pull request
Oct 19, 2017
* [base] Get rid of deprecatedDate type * [date-input] Rename common CSS file used by date input components * [schema] Enable the string-based date type * [date-input] Define string date part * [schema] RichDate type uses date internally * [date-input] Implement new string-based date type * [test-studio] Add string-based date type to test studio schema * [date-input] Include moment for a thinner Date.js * [date-input] Use moment without timezone db * [test-studio] Split dates schema * [date-input] Refactor out some common date methods to a shared file * [date-input] Move simple date input to form-builder and rename @santy/date-input to @sanity/rich-date-input * [base] Import richDate legacy schema from deprecated @sanity/date-input package * [form-builder] Add converter for richDate <=> datetime * [form-buidler] Remove inputUtc option * [form-builder] Disable keyboard navigation in date input * [form-builder] Simplify conversion from richDate to datetime
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.