fix(server): alias styled-components in webpack config #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). perf-studio – ./🔍 Inspect: https://vercel.com/sanity-io/perf-studio/DyZvrmufjq3aj3buk1eGAwiHmHrD test-studio – ./🔍 Inspect: https://vercel.com/sanity-io/test-studio/Ek3DKxzECQkUNDDCT7o7z6jVQZoT |
ricokahler
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aliases
styled-componentsto the version installed in the studio (or a hoisted copy, potentially) within the webpack config. This is done to prevent the error where multiple versions ofstyled-componentsare used in the same app unintentionally. Ideally we wouldn't need this, but it seems npm/yarn hoisting isn't always perfect, so this at least provides some way to alleviate that pain.What to review