Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base): fix usage of inset property #2769

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

sjelfull
Copy link
Member

@sjelfull sjelfull commented Sep 13, 2021

Description

This reverts the usage of inset css property instead of left/right/top/bottom: 0. The property is only supported in Safari 14.1 and up, which was released this year, so we should hold off on using it until support improves.

@vercel
Copy link

vercel bot commented Sep 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/5wv8sbFiV4ALsYmPLABFC6EexctZ
✅ Preview: https://perf-studio-git-fix-revert-use-of-inset.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/8nMmztfR4YaGnfUmTbioDxGBuKnU
✅ Preview: https://test-studio-git-fix-revert-use-of-inset.sanity.build

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sjelfull sjelfull merged commit 3448ee7 into next Sep 13, 2021
@sjelfull sjelfull deleted the fix/revert-use-of-inset branch September 13, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants