refactor(desk-tool): up TS coverage; introduce pane types

[ricokahler]

Description

The following PR:

• Moves files out of lib folders — kind of a small change but we have ignore files at the top-level of the monorepo that target **/lib. I think by convention we shouldn't use lib folder in src (similar to how we shouldn't use dist folders inside of src).
• Hoists the desk-tool types to @sanity/types — The idea behind this move was to make the types for these pane items more accessible and enforceable. The end result is much more descriptive types internally to the desk-tool which should also make it more portable for the future. Eventually these types should be enforced inside of @sanity/structure but that can come at a later time (I did try and it seems too difficult to combine due to many slight type nuances). This was moved to /src/desk-tool/types instead
• Deletes @sanity/base/__legacy/@sanity/components/menu/types — after carefully looking the MenuItem type, I came to the conclusion the type is a desk-tool-only concept and renamed it PaneMenuItem and PaneMenuItemGroup. These types now live in @sanity/types/src/desk-tool and gets us really close to removing the @sanity/base/__legacy/@sanity/components folder 😄 . These types were kept and base was not touched
• Add types to resolvePanes and more — and also removes the stub StructurePane type
• Removes noImplicitAny from the tsconfig 🎉

TODO:

• move new types to desk-tool
• rename PaneXs to PaneXNode etc
• put back legacy types that don't touch legacy directory

What to review

Review #2852 before this one. ✅

Most of the changes are renames and adding types so the review should go quicker than what it seems. Review the new types, the names, and their usage. There was no intention on changing any logic in this one so keep an eye out of anything divergent.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/AzjnuDTAJ1nChKAR7km44hwHqXZi
✅ Preview: https://perf-studio-git-refactor-desk-tool-ts-coverage.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/EnLeABUfrbtjXbDEpLQyHaf1CRt9
✅ Preview: https://test-studio-git-refactor-desk-tool-ts-coverage.sanity.build

studio-workshop – ./dev/workshop

🔍 Inspect: https://vercel.com/sanity-io/studio-workshop/4cKRFqhUVZL3RsC4q8YifePvBSJd
✅ Preview: https://studio-workshop-git-refactor-desk-tool-ts-coverage.sanity.build

[mariuslundgard]

Hoists the desk-tool types to @sanity/types — The idea behind this move was to make the types for these pane items more accessible and enforceable. The end result is much more descriptive types internally to the desk-tool which should also make it more portable for the future. Eventually these types should be enforced inside of @sanity/structure but that can come at a later time (I did try and it seems too difficult to combine due to many slight type nuances).

I think the best is to keep these within @sanity/desk-tool for now. The concept of "panes" is very specific to desk-tool.

Another thought I had when reading these changes, was that I think the Pane interface should be named PaneNode or similar. The reason is that we already have a UI component in desk tool named Pane.

[ricokahler]

note: https://github.com/sindresorhus/leven/releases/tag/v3.0.0 (needed for types)

[ricokahler]

note: https://github.com/sindresorhus/leven/releases/tag/v3.0.0 (needed for types)

[ricokahler]

note: https://github.com/sindresorhus/leven/releases/tag/v3.0.0 (needed for types)

[bjoerge]

LGTM! 👏🏼