[components] Respect disabled prop on input components and cleanup #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kristofferjs
commented
Oct 17, 2017
kristofferjs
commented
- Removing hasFocus, error etc that is no longer in use (yet)
- fixing isSelected on searchable select
- Proper use of :disabled pseudo class where available
…other pros. Removing hasFocus etc that is no longer in use
bjoerge
reviewed
Oct 17, 2017
| @@ -31,7 +31,7 @@ export default class DefaultTextInput extends React.PureComponent { | |||
| onBlur: PropTypes.func, | |||
| isClearable: PropTypes.bool, | |||
| isSelected: PropTypes.bool, | |||
| isDisabled: PropTypes.bool, | |||
| disabled: PropTypes.bool, | |||
There was a problem hiding this comment.
Renaming this is a potential breaking change. Have you searched for usages across other files in the repo?
There was a problem hiding this comment.
Found one use on SlugInput on form-builder. Updated
bjoerge
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.