fix(desk-tool): force re-renders on user components on navigation #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). perf-studio – ./🔍 Inspect: https://vercel.com/sanity-io/perf-studio/DCHNHidBow1KbaKS497AzuSyNNuk test-studio – ./🔍 Inspect: https://vercel.com/sanity-io/test-studio/94DBs7A6xCzsaSKfXQmDTznAjRfs studio-workshop – ./dev/workshop🔍 Inspect: https://vercel.com/sanity-io/studio-workshop/Gf5vR9UuB441k3PLaFtGa1wrhRz1 |
mariuslundgard
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The performance improvements of the desk-tool preserves the instance of the existing child component. For certain edge cases, this behavior is not desired and is unexpected.
This change forces user-defined components to render on pane navigation changes.
Notes for release
Fixes an edge case for user-defined components. All user-defined components are re-rendered on navigation regardless if the structure child is a function or not.