Fix/default login don't add project id param #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
changed the title
skogsmaskin
force-pushed
the
fix/default-login-dont-add-projectId-param
branch
from
ae47971
to
bcee053
Compare
bjoerge
reviewed
Oct 18, 2017
| showSanityLogo: PropTypes.bool.isRequired | ||
| description: PropTypes.string, | ||
| sanityLogo: PropTypes.node, | ||
| showSanityLogo: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
Why do we need both showSanityLogo and sanityLogo? Can't we just show sanity logo if its defined?
There was a problem hiding this comment.
Because sanityLogo can override the default logo content, and showSanityLogo can toggle it.
skogsmaskin
force-pushed
the
fix/default-login-dont-add-projectId-param
branch
2 times, most recently
from
3ade41a
to
67944d0
Compare
skogsmaskin
force-pushed
the
fix/default-login-dont-add-projectId-param
branch
from
67944d0
to
1f9eee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.