Feature/toplevel document type #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the surprising behaviour is acceptable. We will make it clear in the documentation wherever |
simen
approved these changes
Oct 20, 2017
thomax
reviewed
Oct 20, 2017
…hema has any defined document types
bjoerge
force-pushed
the
feature/toplevel-document-type
branch
from
a02fc61
to
4fa9604
Compare
|
I've added a console-warning if there are I've also written a help page for this: https://sanity.io/help/toplevel-objects-to-document-type Good to merge? |
bjoerge
added a commit
that referenced
this pull request
Oct 25, 2017
* [schema] Support type: document * [base] Change type of bundled types to document * [data-aspects] Make getInferredTypes only return document types if schema has any defined document types * [data-aspects] Warn if encountering both document types and a hiddentTypes config * [cli] Remove update movies-schema and remove hiddenTypes from moviesdb template * [misc] Remove references to hiddenTypes config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports
type: 'document'which is in essence an alias for object types, but will be the only types that can be created as documents (with_id), and will also be the only types listed in the side panel by default.This is backwards compatible, except for a little potential surprising side effect: if you now define a new document type in your schema without renaming the existing
objecttypes, all the existing object types will disappear from the sidebar by default. The solution is to change the type of the object types that you want to be documents fromobjecttodocument.I can't think of an easy way to fix this, but maybe its acceptable as long as we document how to fix it? What do you think?