Schema validation #299
Merged
Schema validation #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
feature/schema-validation
branch
from
f5bc6d6
to
6b9391c
Compare
bjoerge
force-pushed
the
feature/schema-validation
branch
from
b045ba2
to
61201ce
Compare
bjoerge
added a commit
that referenced
this pull request
Oct 25, 2017
* [schema] Add a new way to traverse/prepare schema and basic validation infrastructure * [base] Expose validation groups on result of createSchema * [default-layout] Go into 'failure mode' and display schema errors if any * [test-studio] Remove object without fields test case as its now a hard error * [code-input] Fix schema warning * [default-layout] Styling the schema error screen * [schema] Clean up help ids * [schema] Error message improvements + reserve a few more type names * [schema] More help-id cleanup * [schema] Register reference validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a first iteration of better schema validation.
It is based on runtime schema information, and there's currently no way to infer file/line numbers.
There are also quite a few areas of improvements (and the implementation is a bit messy, sorry about that), but it should work as a first version that can be expanded on later.