Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form-builder): fix the number input to accept decimal values when default #3219

Merged
merged 2 commits into from
Mar 28, 2022

Conversation

RitaDias
Copy link
Contributor

Description

Fix issue where the number input wasn't allowing for decimal numbers (when the input is active)

What to review

Check that you can add any decimal number on a basic number schema

Notes for release

Fix issue where the number input wasn't allowing for decimal numbers (when the input is active)

@RitaDias RitaDias requested a review from bjoerge March 28, 2022 08:06
@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/Hob6pQ7cnHRcuRauSHgJ4qXj8i8X
✅ Preview: https://perf-studio-git-bug-sc-16924basic-number-type-fields-are-81679f.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/AQccJ8qFnpmVpNs9WRDcMsXKadsy
✅ Preview: https://test-studio-git-bug-sc-16924basic-number-type-fields-are-edcf26.sanity.build

studio-workshop – ./dev/workshop

🔍 Inspect: https://vercel.com/sanity-io/studio-workshop/FZpmhBfhsWMfJdavKygfS8EWdvYH
✅ Preview: https://studio-workshop-git-bug-sc-16924basic-number-type-fields-7f020a.sanity.build

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RitaDias RitaDias merged commit 94b1b88 into next Mar 28, 2022
@RitaDias RitaDias deleted the bug/sc-16924/basic-number-type-fields-aren-t-behaving branch March 28, 2022 08:10
bjoerge pushed a commit that referenced this pull request Mar 28, 2022
… default (#3219)

* fix(form-builder): fix decimal issues in number input

* test(form-builder): add number input tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants