Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Update login docs #3247

Merged
merged 2 commits into from
Apr 19, 2022
Merged

chore(cli): Update login docs #3247

merged 2 commits into from
Apr 19, 2022

Conversation

geball
Copy link
Contributor

@geball geball commented Apr 14, 2022

Description

Update sanity login docs to reflect --sso option.

What to review

That the help text is displayed correctly and the CLI command works.

Notes for release

Update docs for the sanity login CLI command.

@vercel
Copy link

vercel bot commented Apr 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
perf-studio ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 7:40AM (UTC)
studio-workshop ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 7:40AM (UTC)
test-studio ✅ Ready (Inspect) Visit Preview Apr 19, 2022 at 7:40AM (UTC)

@geball
Copy link
Contributor Author

geball commented Apr 14, 2022

@bjoerge or @RitaDias Hoping that one of you wouldn't mind taking a look. Thanks!

@geball geball removed the request for review from mmgj April 14, 2022 01:09
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)
Noticed that a couple of things of linting which I just pushed a fix for, nice work! ✨

@geball geball merged commit 44b4257 into next Apr 19, 2022
@geball geball deleted the chore/login-docs branch April 19, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants