Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve minification error messages #328

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 2, 2017

Previously:

espenh@plumm ~/webdev/some-studio $ sanity build
✔ Clearing output folder (161ms)
✔ Building Sanity (40934ms)
✔ Building index document (1360ms)
✖ Minifying Javascript bundles
Unexpected token keyword «function», expected punc «,»

With this PR:

espenh@plumm ~/webdev/some-studio $ sanity build
✔ Clearing output folder (221ms)
✔ Building Sanity (33110ms)
✔ Building index document (451ms)
✖ Minifying Javascript bundles
Parse error at /home/espenh/webdev/some-studio/dist/static/js/app.bundle.js:225035,17

    value: async function fetchData() {
                 ^

@rexxars rexxars requested a review from bjoerge November 2, 2017 17:13
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rexxars rexxars merged commit 88d6c92 into next Nov 2, 2017
@rexxars rexxars deleted the improve-minify-errors branch November 2, 2017 18:10
@bjoerge bjoerge mentioned this pull request Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants