Introducing the PresenceStore #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
requested changes
Nov 2, 2017
| this.handleRemoteChange() | ||
| } | ||
| // Update timestamp for this cache key | ||
| this.timestamps[key] = new Date() |
There was a problem hiding this comment.
I'd just use Date.now() instead of an actual Date since you won't actually be using any of the date functionality
| performPurge = () => { | ||
| const now = new Date() | ||
| Object.keys(this.states).forEach(key => { | ||
| const age = now - this.timestamps[key].timestamp |
There was a problem hiding this comment.
Don't think timestamp is a standardized property, but as pointed out earlier, a Date.now() would skip the need for this
| this.connection = connection | ||
| this.unsubscribeListener = this.connection.listen().subscribe(this.handleMessage).unsubscribe | ||
| this.myState = {} | ||
| this.states = {} |
There was a problem hiding this comment.
Perhaps use an ES6 Map for states and timestamps instead? It is more suitable for arbitrary keys, IIRC.
| this.unsubscribeListener() | ||
| clearTimeout(this.resendReportTimer) | ||
| clearInterval(this.performPurgeTimer) | ||
| } |
There was a problem hiding this comment.
There are a couple more timers that should be closed here, I think? changeReportDebounceTimer for instance
…ate.now() instead of new Date()
rexxars
approved these changes
Nov 2, 2017
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
Merged
bjoerge
pushed a commit
that referenced
this pull request
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the store to support the real time presence experience in a Sanity studio.