feat(cli): format dataset copy output with console-table-printer #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RitaDias
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli
branch
from
86e1fae
to
b7c6250
Compare
rexxars
requested changes
Jun 1, 2022
Comment on lines
12
to
15
| table(...args) { | ||
| console.table(...args) | ||
| }, | ||
|
|
There was a problem hiding this comment.
Given that we are using console-table-printer, I don't think this change is needed?
| Returns table of jobs with: | ||
| - jobId | ||
| - current state - pending, completed, failed, terminating, terminated | ||
| - History - With/Without history |
There was a problem hiding this comment.
Suggested change
| - History - With/Without history | |
| - history - whether or not dataset copy included document history |
| } | ||
| } | ||
|
|
||
| function convertTimestampToDaysHoursMinsSecs(timePassedInSeconds) { |
There was a problem hiding this comment.
Can I suggest using shorthand formatting for these, to compress the table some more? Eg instead of 3 days 22 hours 32 minutes 6 seconds it would be 3d 22h 32m 6s
| } | ||
|
|
||
| if (response && response.length > 0) { | ||
| const p = new Table({ |
There was a problem hiding this comment.
I think table would be a more descriptive variable name
rexxars
changed the title
tzhelyazkova
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli
branch
from
b7c6250
to
2eed1ac
Compare
tzhelyazkova
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli-formatting
branch
from
143e0fe
to
7275b86
Compare
vquigley
approved these changes
Jun 1, 2022
rubioz
approved these changes
Jun 1, 2022
j33ty
approved these changes
Jun 1, 2022
Ah, sorry - did not have that context. |
rexxars
approved these changes
Jun 1, 2022
tzhelyazkova
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli
branch
from
2eed1ac
to
3ff9735
Compare
RitaDias
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli
branch
2 times, most recently
from
a488dff
to
61cf425
Compare
Base automatically changed from
feature/sc-18247/list-job-history-sanity-cli
to
next
June 8, 2022 13:40
tzhelyazkova
force-pushed
the
feature/sc-18247/list-job-history-sanity-cli-formatting
branch
from
7275b86
to
c71dc3a
Compare
tzhelyazkova
deleted the
feature/sc-18247/list-job-history-sanity-cli-formatting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the formatting of the
dataset jobs listoutput.Introduces a new npm dependency console-table-printer
With this library we are able to get rid of the index column and the quotes around the values in the table, which are present in the solution with
console.table()