-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): use dataset copy command to list copy dataset jobs #3318
Merged
rexxars
merged 3 commits into
next
from
feature/sc-20830/cli-rename-dataset-copy-jobs-list-command
Jun 9, 2022
Merged
fix(cli): use dataset copy command to list copy dataset jobs #3318
rexxars
merged 3 commits into
next
from
feature/sc-20830/cli-rename-dataset-copy-jobs-list-command
Jun 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tzhelyazkova
changed the title
fix(cli): Use dataset copy command to list copy dataset jobs
fix(cli): use dataset copy command to list copy dataset jobs
Jun 9, 2022
Remove the existing dataset jobs list command (not released yet).
tzhelyazkova
force-pushed
the
feature/sc-20830/cli-rename-dataset-copy-jobs-list-command
branch
from
June 9, 2022 11:30
d0fa22d
to
d0c1f69
Compare
dcilke
reviewed
Jun 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two cents
packages/@sanity/core/src/commands/dataset/copyDatasetCommand.js
Outdated
Show resolved
Hide resolved
packages/@sanity/core/src/commands/dataset/copyDatasetCommand.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Dain Cilke <dain.cilke@gmail.com>
Co-authored-by: Dain Cilke <dain.cilke@gmail.com>
rexxars
deleted the
feature/sc-20830/cli-rename-dataset-copy-jobs-list-command
branch
June 9, 2022 20:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a separate command for listing dataset copy jobs, use the already existing
dataset copy
command by adding a new--list
flag.