Proof of concept/pass down wheel event #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
YOLO. Lets do it! |
|
Cool. Will do the same with touch and test-test-test. |
bjoerge
force-pushed
the
proof-of-concept/pass-down-wheel-event
branch
from
ea580a9
to
081f640
Compare
|
This is now ready to be merged if it passes human browser test. |
bjoerge
force-pushed
the
proof-of-concept/pass-down-wheel-event
branch
from
dcde72d
to
6a82457
Compare
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
bjoerge
force-pushed
the
proof-of-concept/pass-down-wheel-event
branch
from
6a82457
to
a0cead6
Compare
bjoerge
force-pushed
the
proof-of-concept/pass-down-wheel-event
branch
from
a0cead6
to
c920406
Compare
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
bjoerge
pushed a commit
that referenced
this pull request
Nov 7, 2017
Merged
bjoerge
pushed a commit
that referenced
this pull request
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to be merged.
After testing the studio, @bjoerge pointed out that when scrolling a popover, the background does not follow. This is possible by listening to the wheel-event, and setting scrollTop on scrollContainer.
After testing it in this branch, I think it is possible. If we choose this solution we need to do the same with touchEvents to make it work on touch.