[cli] Allow bootstrapping plugins from templates #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
pushed a commit
that referenced
this pull request
Nov 13, 2017
* [cli] Remove sanity-style plugin init code * [cli] Allow bootstrapping plugins from templates * [cli] Add minimum version check to plugin template bootstrap * [cli] Add tool templates * [cli] Don't allow bootstrapping to existing plugin folder
Merged
bjoerge
pushed a commit
that referenced
this pull request
Nov 13, 2017
* [cli] Remove sanity-style plugin init code * [cli] Allow bootstrapping plugins from templates * [cli] Add minimum version check to plugin template bootstrap * [cli] Add tool templates * [cli] Don't allow bootstrapping to existing plugin folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old plugin initialization logic and replaces it with something a little more useful; bootstrapping a plugin from a set of templates. It also allows specifying a URL for a target zip file.