Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base] Fix outdated modules message #363

Merged
merged 1 commit into from
Nov 14, 2017
Merged

[base] Fix outdated modules message #363

merged 1 commit into from
Nov 14, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 14, 2017

The outdated array returned by the backend includes name and version numbers. We were simply joining the array, which results in a bunch of [object Object] 🤦‍♂️

@rexxars rexxars requested a review from bjoerge November 14, 2017 13:06
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💁‍♂️ (facepalm removed)

@rexxars rexxars merged commit 57acc09 into next Nov 14, 2017
@rexxars rexxars deleted the version-checker-fix branch November 14, 2017 13:11
bjoerge pushed a commit that referenced this pull request Nov 15, 2017
@rexxars rexxars mentioned this pull request Nov 24, 2017
rexxars added a commit that referenced this pull request Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants