fix: migrate class components to functions+hooks #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
stipsan
force-pushed
the
v3-react-18-follow-up-fixes
branch
from
ab1bd6c
to
53c57e9
Compare
stipsan
force-pushed
the
v3-react-18-follow-up-fixes
branch
from
53c57e9
to
cb78fd0
Compare
mariuslundgard
force-pushed
the
v3
branch
2 times, most recently
from
b1b4f89
to
febf7a6
Compare
stipsan
force-pushed
the
v3-react-18-follow-up-fixes
branch
from
cb78fd0
to
f4a72d7
Compare
stipsan
force-pushed
the
v3-react-18-follow-up-fixes
branch
from
f4a72d7
to
d47ef86
Compare
packages/sanity/src/form/inputs/files/ImageToolInput/imagetool/HotspotImage.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/form/inputs/files/ImageToolInput/imagetool/ImageLoader.tsx
Outdated
Show resolved
Hide resolved
stipsan
commented
Oct 4, 2022
| import Debug from 'debug' | ||
| import {debounce} from 'lodash' |
There was a problem hiding this comment.
Using startTransition instead, combined with 18's Automatic State Batching it's no longer necessary to debounce event handlers like window.onresize
stipsan
force-pushed
the
v3-react-18-follow-up-fixes
branch
from
d47ef86
to
dfdd446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts problematic class components to function components with hooks to make them ready for React 18 concurrent features. With this PR there's no longer any components left in our codebase that uses
UNSAFE_prefixed legacy lifecycle hooks.