Start block markDefs from empty array #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
approved these changes
Dec 26, 2017
kristofferjs
pushed a commit
that referenced
this pull request
Jan 4, 2018
* [block-tools] Clear mark defs and build from scratch when converting to blocks * [block-tools] Guard against annotation null/undefined values
bjoerge
pushed a commit
that referenced
this pull request
Jan 5, 2018
* [block-tools] Clear mark defs and build from scratch when converting to blocks * [block-tools] Guard against annotation null/undefined values
bjoerge
pushed a commit
that referenced
this pull request
Jan 5, 2018
* [block-tools] Clear mark defs and build from scratch when converting to blocks * [block-tools] Guard against annotation null/undefined values
bjoerge
pushed a commit
that referenced
this pull request
Jan 9, 2018
* [block-tools] Clear mark defs and build from scratch when converting to blocks * [block-tools] Guard against annotation null/undefined values
bjoerge
pushed a commit
that referenced
this pull request
Jan 9, 2018
* [block-tools] Clear mark defs and build from scratch when converting to blocks * [block-tools] Guard against annotation null/undefined values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there were a little snag in the code, where it would initiate the markDefs with existing values. It should always start from an empty array as it builds it up anyway from every span node.