fix: whitelist all standard text decorators in block-tools #4526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjelfull
force-pushed
the
bug/sc-31449/whitelist-all-known-decorators-to-block-tools
branch
from
47eeb2e
to
dd79990
Compare
sjelfull
force-pushed
the
bug/sc-31449/whitelist-all-known-decorators-to-block-tools
branch
from
dd79990
to
f5563e0
Compare
skogsmaskin
approved these changes
May 25, 2023
robinpyon
approved these changes
May 25, 2023
sjelfull
deleted the
bug/sc-31449/whitelist-all-known-decorators-to-block-tools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the whitelist of block-tools to allow highly requested decorators like
sup/sub, as well as any other similar HTML elements that will "just work":mark, ins, small(we already haddelin there).It also updates the README to be more specific that we only will convert a subset of HTML elements, and adds a link to the internal whitelist.
What to review
Notes for release
<sup>,<sub>,<ins>and<mark>in@sanity/block-tools