Fix/add env prefix exceptions #4554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@arjanmalda is attempting to deploy a commit to the Sanity Team on Vercel. A member of the Team first needs to authorize it. |
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
e7bf4c3
to
4151f2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added an array with env keys that should not be prefixed with the default prefix 'SANITY_STUDIO_'.
This has been done because prefixed envs can cause unexpected behaviour in some cases.
For example the default envs from Vercel could previously only be used in the studio, when manually prefixing them with SANITY_STUDIO_.
The tests are failing on Vercel but locally the tests pass and I can build the project. @ reviewer, can you see what is going on in the Vercel test studio?
Steps to review
Please check and (if needed) elaborate on the
envsExceptedFromPrefixarray added in file getStudioEnvironmentVariables.Steps to test
VERCEL_ENVin stead ofSANITY_STUDIO_VERCEL_ENV.Notes for release