Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-builder] Don't force scroll input into view on focus #481

Merged
merged 1 commit into from Jan 10, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 10, 2018

Scrolling into view when an input receives focus is not needed as browsers seem to do this by default anyway. In addition, it messed with sorting in arrays too, so let's remove it.

(also including a few minor flowtype fixes)

Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bjoerge bjoerge merged commit 79e4693 into next Jan 10, 2018
@bjoerge bjoerge deleted the skip-scroll-into-view branch January 10, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants