Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[observable] Upgrade rxjs to 5.5.6, adding .pipe operator #483

Merged
merged 1 commit into from Jan 11, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 11, 2018

RxJS 5.5 introduced the concept of "lettable operators", which is a great way to reduce bundle size by importing just the operators needed, e.g.:

import {map, filter, scan} from 'rxjs/operators';

//...

client.observable
  .listen('*[_id == "somedoc"')
  .pipe(
    filter(doc => doc.isPublished),
    map(doc => doc.count),
    scan((acc, count) => acc + count, 0)
  )
  .subscribe(totalCount => console.log(totalCount))

@bjoerge bjoerge requested a review from rexxars January 11, 2018 07:19
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bjoerge bjoerge merged commit ead321f into next Jan 11, 2018
@bjoerge bjoerge deleted the upgrade-rxjs branch January 11, 2018 09:37
bjoerge added a commit that referenced this pull request Jan 16, 2018
bjoerge added a commit that referenced this pull request Jan 17, 2018
bjoerge added a commit that referenced this pull request Jan 19, 2018
bjoerge added a commit that referenced this pull request Jan 24, 2018
bjoerge added a commit that referenced this pull request Jan 25, 2018
bjoerge added a commit that referenced this pull request Jan 28, 2018
bjoerge added a commit that referenced this pull request Jan 28, 2018
bjoerge added a commit that referenced this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants