Fix/default edit mode dialog #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
requested changes
Jan 12, 2018
| {content} | ||
| </EditItemPopOver> | ||
| <DefaultDialog | ||
| isOpen |
There was a problem hiding this comment.
Is isOpen this really needed? IMO if the dialog shouldn't be open, it should not be rendered at all.
There was a problem hiding this comment.
Now it is needed, but I agree. Lets do that in another branch since it potentially requires a lot of changes
| const actionIndex = event.currentTarget.getAttribute('data-action-index') | ||
| this.props.onAction(this.props.actions[actionIndex]) | ||
| } | ||
| // handleActionClick = event => { |
bjoerge
approved these changes
Jan 12, 2018
kristofferjs
force-pushed
the
fix/default-edit-mode-dialog
branch
from
d8ead95
to
9acd4a5
Compare
bjoerge
pushed a commit
that referenced
this pull request
Jan 12, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 16, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 17, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 19, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 24, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 25, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
bjoerge
pushed a commit
that referenced
this pull request
Jan 30, 2018
* [components] Cleaning up default dialog * [form-builder] Using Default Dialog for editing array content * [pr] Request change from bjoerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.