Design/create screen (wait for #488) #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofferjs
force-pushed
the
design/create-screen
branch
2 times, most recently
from
553cb38
to
c188a09
Compare
bjoerge
requested changes
Jan 12, 2018
| @@ -118,19 +119,32 @@ export default class RenderItemValue extends React.Component<Props> { | |||
| this._focusArea = el | |||
| } | |||
|
|
|||
| handleDialogAction = action => { | |||
| if (!action) { | |||
| console.error('no action') | |||
There was a problem hiding this comment.
Yes. I think it would be nice for a developer to get that error in the console.
| } | ||
| if (action.name === 'delete') { | ||
| //this.handleRemove | ||
| console.log('delete') |
bjoerge
approved these changes
Jan 12, 2018
kristofferjs
force-pushed
the
design/create-screen
branch
from
53d0c1b
to
2a50f92
Compare
bjoerge
pushed a commit
that referenced
this pull request
Jan 12, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 16, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 17, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 19, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 24, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 25, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
bjoerge
pushed a commit
that referenced
this pull request
Jan 30, 2018
* [default-layout] New create new modal * [test-studio] Adding icons to types * [form-builder] Delete wth simple confirm on edit item dialog * [form-builder] Removing console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New menu when clicking on "create new" in main menu