[form-builder] Remove setTimeout workaround for popover focus issue #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
changed the title
kristofferjs
approved these changes
Jan 16, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 16, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 17, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 19, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 24, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 25, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 28, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 28, 2018
bjoerge
added a commit
that referenced
this pull request
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So turns out the
setTimeout-hack that I used to fix an issue with focus in popovers caused more problems than it solved (who could have guessed?!).It caused focus to sometimes get stuck jumping really fast between inputs, which is less desirable than losing focus state on an element inside a popover (which should be fixed separately).