feat(facelift): create StudioUI tooltip with delay and replace #5016

ninaandal · 2023-10-19T11:32:51Z

Description

Starting the work of Studio UI - this PR adds the StudioUI tooltip with an globally added delay, but passes on the other props.
Since the StudioUI tooltuip now have a default padding, this PR also removes the paddings added to the tooltips for consistency.

What to review

Since this PR changes all tooltips in the studio, all of them should be properly tested to make sure they are looking as they should

Adding some videos to show where many of the tooltips can be found:

Screen.Recording.2023-10-24.at.20.45.40.mov

Screen.Recording.2023-10-24.at.20.45.10.mov

Screen.Recording.2023-10-24.at.20.47.49.mov

Screen.Recording.2023-10-24.at.20.53.46.mov

Notes for release

vercel · 2023-10-19T11:32:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 26, 2023 1:30pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2023 1:30pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 26, 2023 1:30pm

github-actions · 2023-10-19T11:35:55Z

Package	Documentation Change
sanity	-7%
@sanity/types	-13%

Full Report

@sanity/diff

This branch	Next branch
13 documented	13 documented
16 not documented	16 not documented

@sanity/block-tools

This branch	Next branch
4 documented	4 documented
9 not documented	9 not documented

sanity/desk

This branch	Next branch
83 documented	83 documented
55 not documented	55 not documented

@sanity/portable-text-editor

This branch	Next branch
21 documented	21 documented
44 not documented	44 not documented

@sanity/mutator

This branch	Next branch
7 documented	7 documented
4 not documented	4 not documented

@sanity/cli

This branch	Next branch
1 documented	1 documented
30 not documented	30 not documented

@sanity/schema/_internal

This branch	Next branch
0 documented	0 documented
9 not documented	9 not documented

@sanity/util/paths

This branch	Next branch
1 documented	1 documented
15 not documented	15 not documented

sanity/router

This branch	Next branch
15 documented	15 documented
21 not documented	21 not documented

@sanity/util/legacyDateFormat

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

@sanity/schema

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

sanity/cli

This branch	Next branch
2 documented	2 documented
0 not documented	0 not documented

@sanity/vision

This branch	Next branch
0 documented	0 documented
2 not documented	2 not documented

@sanity/util/fs

This branch	Next branch
0 documented	0 documented
3 not documented	3 not documented

sanity/_internal

This branch	Next branch
0 documented	0 documented
1 not documented	1 not documented

@sanity/util/content

This branch	Next branch
1 documented	1 documented
5 not documented	5 not documented

sanity

This branch	Next branch
110 documented	119 documented
834 not documented	825 not documented

@sanity/types

This branch	Next branch
46 documented	53 documented
240 not documented	233 not documented

github-actions · 2023-10-19T11:37:54Z

Component Testing Report Updated Oct 26, 2023 1:32 PM (UTC)

File	Status	Duration	Passed
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	11s	3
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	10s	6
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	14s	9
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	51s	18
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	11s	6
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	7s	3

packages/sanity/src/ui/tooltip/Tooltip.tsx

…oltips with this logic

robinpyon

Thanks @ninaandal – interesting to see exactly how many instances there are (and how much variance there is layout wise).

Upon using it, maybe we'll want to tweak that delay slightly (but this change makes it much easier to do so globally)

Left a minor comment on tooltip styling but otherwise LGTM!

packages/sanity/src/ui/tooltip/Tooltip.tsx

Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com>

* feat(facelift): create StudioUI tooltip with delay and replace * fix(core/desk): use StudioUi Tooltip * fix(core/desk): use Studio UI tooltip * fix(core/desk): use StudioUI tooltip and remove paddings * fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error * fix(src): fix studioUI tooltip to take strings and replace current tooltips with this logic * fix(vision): change tooltip import path * fix(src): fix up content in StudioUI tooltips, remove comment * fix(core): add two arguments to forwardRef render function * fix(test-studio): add custom badge to author schema type * Update packages/sanity/src/ui/tooltip/Tooltip.tsx Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com> * refactor: slightly DRY tooltip component --------- Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com> Co-authored-by: Robin Pyon <robin.pyon@gmail.com>

vercel bot deployed to Preview – performance-studio October 19, 2023 11:35 View deployment

vercel bot deployed to Preview – test-studio October 19, 2023 11:36 View deployment

vercel bot deployed to Preview – performance-studio October 19, 2023 11:54 View deployment

vercel bot deployed to Preview – test-studio October 19, 2023 11:55 View deployment

vercel bot deployed to Preview – performance-studio October 19, 2023 13:14 View deployment

vercel bot had a problem deploying to Preview – test-studio October 19, 2023 13:15 Failure

vercel bot deployed to Preview – performance-studio October 19, 2023 13:21 View deployment

vercel bot deployed to Preview – performance-studio October 19, 2023 13:23 View deployment

vercel bot had a problem deploying to Preview – test-studio October 19, 2023 13:24 Failure

pedrobonamin reviewed Oct 20, 2023

View reviewed changes

packages/sanity/src/ui/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview – test-studio October 23, 2023 12:42 Failure

vercel bot deployed to Preview – performance-studio October 23, 2023 12:42 View deployment

ninaandal added 6 commits October 23, 2023 16:19

feat(facelift): create StudioUI tooltip with delay and replace

3945ec9

fix(core/desk): use StudioUi Tooltip

0466803

fix(core/desk): use Studio UI tooltip

01db122

fix(core/desk): use StudioUI tooltip and remove paddings

07e34cb

fix(core): use StudioUI tooltip for TooltipOfDisabled - ref prop error

266eaee

fix(src): fix studioUI tooltip to take strings and replace current to…

f51396e

…oltips with this logic

ninaandal force-pushed the edx-472-revised branch from 281ad1a to f51396e Compare October 23, 2023 14:19

vercel bot deployed to Preview – performance-studio October 23, 2023 14:21 View deployment

vercel bot had a problem deploying to Preview – test-studio October 23, 2023 14:21 Failure

fix(vision): change tooltip import path

e862a3b

vercel bot deployed to Preview – performance-studio October 23, 2023 17:41 View deployment

vercel bot deployed to Preview – test-studio October 23, 2023 17:42 View deployment

fix(src): fix up content in StudioUI tooltips, remove comment

63c3b99

vercel bot deployed to Preview – performance-studio October 24, 2023 11:47 View deployment

vercel bot deployed to Preview – test-studio October 24, 2023 11:47 View deployment

ninaandal marked this pull request as ready for review October 24, 2023 11:51

ninaandal requested review from skogsmaskin and bjoerge as code owners October 24, 2023 11:51

fix(core): add two arguments to forwardRef render function

1fbcdc5

vercel bot temporarily deployed to Preview – test-studio October 24, 2023 18:39 Inactive

vercel bot deployed to Preview – performance-studio October 24, 2023 19:20 View deployment

fix(test-studio): add custom badge to author schema type

e90c6bc

vercel bot deployed to Preview – performance-studio October 24, 2023 19:47 View deployment

vercel bot deployed to Preview – test-studio October 24, 2023 19:49 View deployment

ninaandal requested a review from robinpyon October 25, 2023 09:13

robinpyon reviewed Oct 25, 2023

View reviewed changes

packages/sanity/src/ui/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved

Update packages/sanity/src/ui/tooltip/Tooltip.tsx

a91379c

Co-authored-by: Robin Pyon <robinpyon@users.noreply.github.com>

vercel bot deployed to Preview – performance-studio October 26, 2023 09:50 View deployment

vercel bot deployed to Preview – test-studio October 26, 2023 09:51 View deployment

vercel bot deployed to Preview – performance-studio October 26, 2023 13:18 View deployment

vercel bot deployed to Preview – test-studio October 26, 2023 13:19 View deployment

refactor: slightly DRY tooltip component

a15d186

robinpyon force-pushed the edx-472-revised branch from b8acec7 to a15d186 Compare October 26, 2023 13:26

vercel bot deployed to Preview – performance-studio October 26, 2023 13:28 View deployment

robinpyon approved these changes Oct 26, 2023

View reviewed changes

vercel bot deployed to Preview – test-studio October 26, 2023 13:30 View deployment

ninaandal merged commit 13d0c3e into feat/facelift-mvi-2 Oct 30, 2023
17 checks passed

ninaandal deleted the edx-472-revised branch October 30, 2023 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(facelift): create StudioUI tooltip with delay and replace #5016

feat(facelift): create StudioUI tooltip with delay and replace #5016

ninaandal commented Oct 19, 2023 •

edited

vercel bot commented Oct 19, 2023 •

edited

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023 •

edited

robinpyon left a comment

feat(facelift): create StudioUI tooltip with delay and replace #5016

feat(facelift): create StudioUI tooltip with delay and replace #5016

Conversation

ninaandal commented Oct 19, 2023 • edited

Description

What to review

Notes for release

vercel bot commented Oct 19, 2023 • edited

github-actions bot commented Oct 19, 2023

github-actions bot commented Oct 19, 2023 • edited

robinpyon left a comment

Choose a reason for hiding this comment

ninaandal commented Oct 19, 2023 •

edited

vercel bot commented Oct 19, 2023 •

edited

github-actions bot commented Oct 19, 2023 •

edited