fix(portable-text-editor): allow user event handlers on Editable component #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r for Editable These props should be able to be overridden and potentially stopped before performing our internal behaviour.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
skogsmaskin
force-pushed
the
fix/pte-misc
branch
from
b0d52bf
to
4feac32
Compare
|
No changes to documentation |
|
Component Testing Report Updated Oct 24, 2023 11:57 AM (UTC)
|
skogsmaskin
added a commit
that referenced
this pull request
Nov 2, 2023
…onent (#5058) * fix(portable-text-editor): allow overriding onKeyDown, onFocus, onBlur for Editable These props should be able to be overridden and potentially stopped before performing our internal behaviour. * fix(portable-text-editor): specify InputEvent event type for TS-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow the consumer to specify their own
onKeyDown,onFocus, andonBlurevent handlers on theEditablecomponent of the PTE in addition to the internal ones.Also fixed a prop typing (
onBeforeInput) that was problematic to use.What to review
That the code looks alright.
Notes for release
N/A