Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mutator): apply setIfMissing prior to set #5062

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Oct 24, 2023

Description

Fixes an issue where the order of operations of set/setIfMissing is reversed from what Content Lake does. By applying setIfMissing first, it ensures we can "prepare" structures that a deep set operation might use, for instance.

What to review

  • Mutations still work and apply as before

Notes for release

  • Fixes an issue where certain patches would apply differently in the studio and in Content Lake, leading to the studio UI not reflecting new values for certain fields

@rexxars rexxars requested a review from a team October 24, 2023 16:14
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 24, 2023 4:16pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 4:16pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 24, 2023 4:16pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Oct 24, 2023 4:22 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 15s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 50s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you <3

@rexxars rexxars added this pull request to the merge queue Oct 24, 2023
Merged via the queue into next with commit 8b4ec5d Oct 24, 2023
21 checks passed
@rexxars rexxars deleted the fix/mutator-setifmissing-first branch October 24, 2023 17:07
skogsmaskin pushed a commit that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants