Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mutator): restore greater than/less than in jsonmatch constraints #5063

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Oct 24, 2023

Description

Using the >= or <= attributes in JSONMatch filters would crash the mutator. The tokenizer found a > or < and consumed it as a token, yielding a lone =, which is not a valid token. Fixed by altering the order that the JSONMatch symbols are consumed in, so that longer ones are consumed first.

Fixes #2474

What to review

  • JSONMatch patches gets correctly applied

Notes for release

  • Fixed an issue where using >= or <= in JSONMatch filters for patch operations would cause the studio to give error messages and not apply patch correctly

@rexxars rexxars requested a review from a team October 24, 2023 16:48
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 24, 2023 4:48pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 4:48pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 24, 2023 4:48pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

Component Testing Report Updated Oct 24, 2023 4:56 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 17s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 54s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@rexxars rexxars added this pull request to the merge queue Oct 27, 2023
Merged via the queue into next with commit fd7db60 Oct 27, 2023
21 checks passed
@rexxars rexxars deleted the fix/mutator-gt-lt-jsonmatch branch October 27, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONMatch array patch invalid tokens in Studio, sparse documentation
2 participants