fix(desk): edit logic for published- and edit status message in document list

[ninaandal]

Description

The logic for published and edits message in the document list was wrong and would be incorrect in certain instances.
This was also the case for the PublishAction tooltip.

Before:

Instead of using <TimeAgo />, we can use useTimeAgo() and show label with abbreviations and suffix.

What to review

The document list published and edits status.

Notes for release

Fixed published and edits message in document list

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Oct 30, 2023 11:50am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2023 11:50am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 30, 2023 11:50am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Oct 30, 2023 11:54 AM (UTC)

File	Status	Duration	Passed	Skipped	Failed
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	10s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	11s	3	0	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	11s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	31s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	15s	9	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	59s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	11s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	7s	3	0	0

[robinpyon]

Great find @ninaandal

Since this issue lies with the <TimeAgo> component – perhaps it makes sense to find other places that's used (I think there are just 1-2), apply this same fix and then remove that component altogether?

[bjoerge]

Nice, good catch & thanks for fixing!

[ninaandal]

Great find @ninaandal

Since this issue lies with the <TimeAgo> component – perhaps it makes sense to find other places that's used (I think there are just 1-2), apply this same fix and then remove that component altogether?

There are several <TimeAgo /> components and I think it makes sense to keep as is for the preview components (reference and CDR reference) as this shows how long ago it was (like almost two years ago instead of the date it was published). But I'll remove the one that is used for the PublishAction as this can be replaced with useTimeAgo()

[robinpyon]

Thanks @ninaandal!

I think it makes sense to keep as is for the preview components (reference and CDR reference) as this shows how long ago it was (like almost two years ago instead of the date it was published).

(nitpicking and not blocking) I would opt for consistency here – as rolling over these publish icons in different contexts currently yields different values (document list previews say "published yesterday", whilst reference inputs say "published 1 day ago"). Whilst we may know they're different components, it may not be apparent to users.

Screenflick.Movie.15.mp4

[ninaandal]

Thanks @ninaandal!

I think it makes sense to keep as is for the preview components (reference and CDR reference) as this shows how long ago it was (like almost two years ago instead of the date it was published).

(nitpicking and not blocking) I would opt for consistency here – as rolling over these publish icons in different contexts currently yields different values (document list previews say "published yesterday", whilst reference inputs say "published 1 day ago"). Whilst we may know they're different components, it may not be apparent to users.

Screenflick.Movie.15.mp4

We should make a decision of which format we would like then, as the reference preview one uses date-fns/formatDistanceToNow to format, while the document list items does not.
Do we want it to have the format: Published about 1 years ago for example, or just show the date when it was published (see the two screenshots)?
Maybe @kaylasanity wants to chime in here?

[ninaandal]

Had a chat with @kaylasanity and decided to go for the timestamp format ✨