Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): jest 29 migration #5069

Merged
merged 18 commits into from
Oct 26, 2023
Merged

chore(test): jest 29 migration #5069

merged 18 commits into from
Oct 26, 2023

Conversation

binoy14
Copy link
Contributor

@binoy14 binoy14 commented Oct 25, 2023

Description

This PR upgrades jest to v29 and adds sharding to jest tests saving about 8 mins on the run. (We can tweak number of shards and see if it speeds up things more as needed but this is the first pass at it)

Thanks to @sjelfull for starting this branch I took most of his work and added to it!

Fixes SDX-800

What to review

Tests pass

Notes for release

  • N/A

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Oct 26, 2023 2:32pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 2:32pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 2:32pm

@github-actions
Copy link
Contributor

No changes to documentation

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Component Testing Report Updated Oct 26, 2023 2:36 PM (UTC)

File Status Duration Passed Skipped Failed
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 8s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 24s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 13s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 49s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 9s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 5s 3 0 0

@socket-security
Copy link

socket-security bot commented Oct 25, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jest-environment-jsdom 29.7.0 eval +10 761 kB simenb
@types/connect-history-api-fallback 1.5.2 None +0 4.87 kB types
jest-dev-server 9.0.0...9.0.1 None +2/-2 26.5 kB neoziro
jest-environment-node 27.5.1...29.7.0 None +20/-9 1.51 MB simenb
jest 27.5.1...29.7.0 None +118/-116 5.91 MB simenb
babel-jest 27.5.1...29.7.0 None +13/-14 1.05 MB simenb
@types/jest 27.5.2...29.5.6 eval +22/-8 1.83 MB types
@testing-library/jest-dom 5.16.5...5.17.0 None +28/-14 2.45 MB testing-library-bot

🚮 Removed packages: react-scripts@5.0.1

@socket-security
Copy link

socket-security bot commented Oct 25, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it running all the tests on the CI now?

@skogsmaskin
Copy link
Member

Is it running all the tests on the CI now?

Found them :)

@bjoerge
Copy link
Member

bjoerge commented Oct 26, 2023

Really amazing work, @binoy14 and @sjelfull! 🎉

@binoy14 binoy14 added this pull request to the merge queue Oct 26, 2023
Merged via the queue into next with commit fd3a972 Oct 26, 2023
29 checks passed
@binoy14 binoy14 deleted the chore/jest-28-migration-rebase branch October 26, 2023 14:41
skogsmaskin added a commit that referenced this pull request Nov 2, 2023
* chore: migrate to jest 28

* chore: test jest sharding

* chore(test): ignore playwright tests

* chore(test): revert ci changes from base

* chore(test): add sharding

* chore(test): fix shard dataset name and remove unused deps

* chore(test): split install and test jobs

* chore(test): restore npm cache in test step

* chore(test): add install step

* chore(test): fix cache name

* chore(test): install playwright in test steps

* chore(test): move playwright install after install

* chore(test): upgrade to jest 29

* chore(test): dedupe yarn.lock

* chore(dev): remove the create react app starter example

* chore(deps): add missing dev dependency

* chore(portable-text-editor): speed up tests

* chore(portable-text-editor): update jest-dev-server

---------

Co-authored-by: Fred Carlsen <fred@sjelfull.no>
Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
Co-authored-by: Per-Kristian Nordnes <per.kristian.nordnes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants