Design/mobile fixes #509
Merged
Design/mobile fixes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
reviewed
Jan 18, 2018
| @@ -203,6 +203,16 @@ export default class ReferenceInput extends React.Component<Props, State> { | |||
| const hasRef = value && value._ref | |||
| const hasWeakMismatch = hasRef && !isMissing && weakIs !== weakShouldBe | |||
|
|
|||
| let inputValue | |||
There was a problem hiding this comment.
For readability, maybe you could create a function that takes the preview snapshot and returns the input value?
function resolveInputValue(snapshot) {
if (snapshot === MISSING_SNAPSHOT) {
return '<Unpublished or missing document>'
}
return snapshot.title || 'Untitled document'
}
// and then when passing the prop:
inputValue={resolveInputValue(previewSnapshot)}There was a problem hiding this comment.
Tried it, but it always returns 'untitled document' when the component should show the placeholder.
There was a problem hiding this comment.
Weird. It should be equivalent, except that it should probably be a guard against snapshot being null. Let me fix it.
There was a problem hiding this comment.
Actually, the else-if block here will never evaluate as the first if block evaluates to true if previewSnapshot is MISSING_SNAPSHOT. Something was wonky with the indentation here too. Will fix in next
There was a problem hiding this comment.
You were right, ofc, cause my suggestion did not consider if the input had a value.
Not entirely certain it became more readable, but at least it's fixed in next (5f2a79b) (squashed my patch into yours in a rebase, together with a fixup of the commit message)
bjoerge
requested changes
Jan 18, 2018
bjoerge
pushed a commit
that referenced
this pull request
Jan 18, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 19, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 24, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 25, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 28, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 30, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
bjoerge
pushed a commit
that referenced
this pull request
Jan 30, 2018
* [components] Better dialog for mobile * [components] Removing border on default pane * [design] Styling button collections * [design] Styling datepicker * [design] General mobile fixes * [components] Searchable select. Arrow down and handle value with no title * [design] Mobile fixes * [components] General padding of functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.