Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[desk-tool] Provide a way to link from a document to a production preview #521

Merged
merged 1 commit into from Jan 24, 2018
Merged

[desk-tool] Provide a way to link from a document to a production preview #521

merged 1 commit into from Jan 24, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 23, 2018

Here's a proposal for how we can support a way to link to a document on site from the studio.

kristofferjs
kristofferjs approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

rexxars
rexxars approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean. I like it. Perhaps we could provide defaults for title and icon?

@bjoerge
Copy link
Member Author

bjoerge commented Jan 24, 2018 •
edited

A few additions:

  • The part ID was renamed to part:@sanity/production-preview/resolve-production-url
  • Added plugin @sanity/production-preview that must be installed in order for the menu item to appear. We do this in order to make sure we can provide a smooth migration path in the future by tracking backward compatibility in this plugin.
  • Removed the possibility to customize title and icon, the function can only return an URL string and the title will always be "Open preview".
  • Using Ctrl+Shift+O as hotkey.

@bjoerge bjoerge changed the title [desk-tool] Rough sketch - provide a way to link from studio to site [desk-tool] Provide a way to link from a document to a production preview Jan 24, 2018
@bjoerge bjoerge force-pushed the production-preview-menu-item branch from b26a8f4 to 01a881f Compare January 24, 2018 15:27
@bjoerge bjoerge force-pushed the production-preview-menu-item branch from 01a881f to 82fdd41 Compare January 24, 2018 15:33
@bjoerge bjoerge merged commit f0a45fc into next Jan 24, 2018
@bjoerge bjoerge deleted the production-preview-menu-item branch January 24, 2018 15:34
bjoerge added a commit that referenced this pull request Jan 24, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
8ee2427 
…view (#521)
bjoerge added a commit that referenced this pull request Jan 25, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
39eee6d 
…view (#521)
bjoerge added a commit that referenced this pull request Jan 28, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
d611537 
…view (#521)
bjoerge added a commit that referenced this pull request Jan 28, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
b90f31d 
…view (#521)
bjoerge added a commit that referenced this pull request Jan 30, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
ac77430 
…view (#521)
bjoerge added a commit that referenced this pull request Jan 30, 2018
@bjoerge
[desk-tool] Provide a way to link from a document to a production pre…
7c87e0e 
…view (#521)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

@kristofferjs kristofferjs kristofferjs approved these changes

@evenwestvang evenwestvang Awaiting requested review from evenwestvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjoerge @rexxars @kristofferjs