Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Hoist eslint, babel, prettier and flow setup #533

Merged
merged 6 commits into from Jan 28, 2018
Merged

[chore] Hoist eslint, babel, prettier and flow setup #533

merged 6 commits into from Jan 28, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 28, 2018

This moves all eslint, babel and flowtype dependencies + config files to project root.

@bjoerge bjoerge requested a review from rexxars January 28, 2018 14:49
@rexxars
Copy link
Member

rexxars commented Jan 28, 2018

Love it! Great work!

@bjoerge
Copy link
Member Author

bjoerge commented Jan 28, 2018 •
edited

Thanks! Also added back a few project-specific .eslintrc files to override import/no-commonjs rules for the packages where it still make sense to keep commonjs. Also added prettier config. When we decide its time to convert to prettier, we can now just change the prettier/prettier-config in .eslintrc and run eslint --fix.

Should probably bee coordinated with the rest of the team, though.

@bjoerge bjoerge changed the title [chore] Hoist eslint, babel and flow setup [chore] Hoist eslint, babel, prettier and flow setup Jan 28, 2018
@bjoerge bjoerge merged commit 4b1d5d1 into next Jan 28, 2018
@bjoerge bjoerge deleted the hoist-tooling branch January 28, 2018 18:51
@bjoerge bjoerge mentioned this pull request Jan 29, 2018
Merged
bjoerge added a commit that referenced this pull request Jan 30, 2018
@bjoerge
[chore] Hoist eslint, babel and flow setup (#533)
7cb80e5 
[chore] Hoist eslint, babel, prettier and flow setup
bjoerge added a commit that referenced this pull request Jan 30, 2018
@bjoerge
[chore] Hoist eslint, babel and flow setup (#533)
c0aaadf 
[chore] Hoist eslint, babel, prettier and flow setup
rexxars pushed a commit that referenced this pull request Jan 26, 2022
@bjoerge
[chore] Hoist eslint, babel and flow setup (#533)
c5c1fb4 
[chore] Hoist eslint, babel, prettier and flow setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjoerge @rexxars