[all] Adding support for and styling readOnly fields. #440 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristofferjs
force-pushed
the
fix/read-only-inputs
branch
from
0858048
to
09a9f0c
Compare
bjoerge
requested changes
Feb 15, 2018
| @@ -45,7 +45,7 @@ export default class RadioSelect extends React.Component { | |||
| } | |||
|
|
|||
| render() { | |||
| const {items, value, name, direction} = this.props | |||
| const {items, value, name, direction, readOnly} = this.props | |||
There was a problem hiding this comment.
readOnly is missing in props validation
| @@ -174,13 +177,13 @@ export default class StatelessSearchableSelect extends React.PureComponent { | |||
| ) | |||
| } | |||
| { | |||
| onClear && value && ( | |||
| onClear && value && !this.props.readOnly && ( | |||
There was a problem hiding this comment.
It would be better to destruct readOnly along with the rest of the props
| <button type="button" className={styles.clearButton} onClick={onClear}> | ||
| <CloseIcon color="inherit" /> | ||
| </button> | ||
| ) | ||
| } | ||
| {!isLoading && ( | ||
| {!isLoading && !this.props.readOnly && ( |
There was a problem hiding this comment.
Access the destructed variable here too
bjoerge
force-pushed
the
fix/read-only-inputs
branch
from
09a9f0c
to
97ce18e
Compare
bjoerge
force-pushed
the
fix/read-only-inputs
branch
2 times, most recently
from
1ab80aa
to
afcff27
Compare
|
I think this is good to merge now. I've made sure the |
bjoerge
approved these changes
Feb 15, 2018
- Inherit readOnly on container type inputs - Support visual readOnly state on image types
kristofferjs
force-pushed
the
fix/read-only-inputs
branch
from
e936ef5
to
f82c45a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge yet.
Needs to pass down
readOnlyto children of array and objects. (@bjoerge)