feat(cli): --quickstart flag for ejecting server schemas #5797
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Mar 4, 2024 4:14 PM (UTC)
|
RostiMelk
changed the title
| @@ -66,8 +67,17 @@ import { | |||
| // eslint-disable-next-line no-process-env | |||
| const isCI = process.env.CI | |||
|
|
|||
| /** | |||
| * @deprecated - No longer used | |||
| */ | |||
| export interface InitOptions { | |||
There was a problem hiding this comment.
This Interface is never used. Can it be removed to avoid confusion?
There was a problem hiding this comment.
Good call. Looks like it's been superseded by InitFlags.
There was a problem hiding this comment.
Do you want to remove it? Maybe better to do it in a separate PR
| // We're authenticated, now lets select or create a project | ||
| debug('Prompting user to select or create a project') |
There was a problem hiding this comment.
All this code is moved into its own function getProjectDetails
| @@ -66,8 +67,17 @@ import { | |||
| // eslint-disable-next-line no-process-env | |||
| const isCI = process.env.CI | |||
|
|
|||
| /** | |||
| * @deprecated - No longer used | |||
| */ | |||
| export interface InitOptions { | |||
There was a problem hiding this comment.
Do you want to remove it? Maybe better to do it in a separate PR
There was a problem hiding this comment.
Great work! Looks good from my side. Do you want/need a final approval from @joneidejohnsen re: the telemetry question below? (Edit: approved)
Description
This PR aims to add a
--quickstartflag for initiating a project from a remote schema.Beware that this new flag overrides some existing flags, as this data is already known and fetched from the API.
--project--dataset--template--visibilityFixes: GRO-1285, GRO-1589
What to review
--quickstartand--templateflags result in a CLI error.Testing
Run
initwith--quickstartflag:Warning
Endpoints are still being built, will update once this whole flow works
Notes for release
I don't think we need to announce anything here. Flag should only be used in onboarding flow