-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portable-text-editor): preserve keys on undo/redo #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Feb 28, 2024 12:12 PM (UTC)
|
skogsmaskin
force-pushed
the
feat/pte-preserve-keys-on-undo-redo
branch
from
February 21, 2024 11:12
d22d2ef
to
fb5930a
Compare
skogsmaskin
force-pushed
the
feat/pte-preserve-keys-on-undo-redo
branch
from
February 21, 2024 13:13
fb5930a
to
daabcdb
Compare
sjelfull
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! No deep knowledge here on my part, but I can't find any issues in normal use.
skogsmaskin
force-pushed
the
feat/pte-preserve-keys-on-undo-redo
branch
from
February 23, 2024 07:43
daabcdb
to
ca05290
Compare
skogsmaskin
force-pushed
the
feat/pte-preserve-keys-on-undo-redo
branch
from
February 23, 2024 11:30
ca05290
to
4ec9774
Compare
skogsmaskin
force-pushed
the
feat/pte-preserve-keys-on-undo-redo
branch
from
February 28, 2024 12:02
4ec9774
to
5f85425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when doing undo/redo in the PortableTextEditor it would generate new keys for the created content.
With this change, the keys will be preserved along with the original content. This makes it possible to support situations where something externally depends on the previous content's keys, it will be possible to restore that dependency when calling undo after an operation breaks it.
I have also introduced some unit tests for undo/redo that will test this functionality. Previously we only had e2e tests for undo/redo.
What to review
Manual testing, unit test, and e2e tests seem to verify that there are no issues with this change.
But could it be something we are not thinking of here?
Testing
It should be covered by various tests.
Notes for release