[form-builder] Show paste enable on uploadplaceholder #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
reviewed
Feb 9, 2018
| } | ||
|
|
||
| .eyeRight { | ||
| /* animation: eye-right_d 1s linear both; */ |
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable complexity */ | |||
There was a problem hiding this comment.
linter underlines everything and makes it hard to read (complexity warning). We should consider change the eslint settings.
There was a problem hiding this comment.
Yeah, I noticed afterward that warning has started to appear in deeply nested jsx now. Looks like a bug in eslint, actually. Just leave it for now :)
bjoerge
force-pushed
the
active-state-on-paste-file
branch
from
4a91202
to
43c885f
Compare
bjoerge
force-pushed
the
active-state-on-paste-file
branch
from
43c885f
to
60b847c
Compare
bjoerge
pushed a commit
that referenced
this pull request
Feb 15, 2018
* [form-builder] Show paste enable on uploadplaceholder * [form-builder] Remove debug * [form-builder] Focus-state on uploadarea on imageInput * [form-builder] Pass onFocus/onBlur to image/file fields
bjoerge
pushed a commit
that referenced
this pull request
Feb 16, 2018
* [form-builder] Show paste enable on uploadplaceholder * [form-builder] Remove debug * [form-builder] Focus-state on uploadarea on imageInput * [form-builder] Pass onFocus/onBlur to image/file fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.