Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add onFullScreenChange to Portable Text Input #5879

Merged
merged 2 commits into from Feb 29, 2024
Merged

feat(core): add onFullScreenChange to Portable Text Input #5879

merged 2 commits into from Feb 29, 2024

Conversation

hermanwikner
Copy link
Member

Description

This pull request adds an onFullScreenChange callback to the Portable Text Input.

What to review

  • Make sure that the callback returns the correct value.

Notes for release

N/A

@hermanwikner hermanwikner requested review from a team as code owners February 29, 2024 13:07
@hermanwikner hermanwikner requested review from skogsmaskin and bjoerge and removed request for a team February 29, 2024 13:07
@vercel Vercel
Copy link

vercel bot commented Feb 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 29, 2024 1:10pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 1:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 29, 2024 1:10pm

@hermanwikner hermanwikner removed the request for review from bjoerge February 29, 2024 13:07
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@skogsmaskin skogsmaskin added this pull request to the merge queue Feb 29, 2024
Merged via the queue into next with commit 84a0c90 Feb 29, 2024
23 of 27 checks passed
@skogsmaskin skogsmaskin deleted the feat/pt-input-toggle-fullscreen-cb branch February 29, 2024 13:11
@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Feb 29, 2024 1:15 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@Cdaprod Cdaprod mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hermanwikner @skogsmaskin