fix(core): updates to not show "cannot upload" on hover #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tension based accepts settings
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Feb 29, 2024 7:51 PM (UTC)
|
cngonzalez
approved these changes
Mar 1, 2024
| if (fileName) { | ||
| return fileName.toLowerCase().endsWith(validType) | ||
| } | ||
| // If we do not have a valid fileName and validType is an extension, we |
There was a problem hiding this comment.
Looks good to me!
nit: I had to take a little time to understand what was going on here. If I understand correctly, we pass true here to not get an error state since the filename is not available. However, when the file is dropped, the accept rule will be enforced later on and an invalid type will not be accepted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using extension based accepts settings
Fixes EDX-795
Description
When configuring a file input that restricts file types, we accept either extensions
'.pdf'or mime type'application/pdf'. When using drag and drop, while hovering, if the file type is not accepted, we display an error message. In order for the extension based restriction to work, we need the file name, which is not passed by the browser when hovering, but is when the file is dropped. Because of this, when an extension rule was used, we were incorrectly showing the error message but then accepting the file when it was dropped. The correct fix is to update the rule to be based on mime type. For the case where extension rules are used, we should not show an error on hover.Before:
Screen.Recording.2024-02-29.at.2.35.05.PM.mov
After:
Screen.Recording.2024-02-29.at.2.31.59.PM.mov
What to review
Are there any side effects of this change that I did not consider?
Testing
Manually tested
Notes for release