fix(core): allow _dataset for cross-dataset references in templates

[rexxars]

Description

It is currently not possible to create a cross-dataset reference from an initial value template, as the template validation runs and disallows unknown properties on references, where _dataset was not an allowed prop.

Perhaps we should recurse down the type chain to look for a field that extends from crossDatasetReference, but this is beyond what we do for other types - eg we do not check for a reference type when encountering _ref. Leaving this for a future iteration to improve on if we feel it is worth it.

What to review

• Can create a cross-dataset reference from an initial value template
• Implementation looks acceptable

Testing

I added some surrounding tests not only for the _dataset case but also for other reference properties, as I could not find any tests for that code path.

Notes for release

• Fixes an issue where initial value templates could not define a target dataset for cross-dataset references

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview	Mar 2, 2024 0:18am
test-studio	✅ Ready (Inspect)	Visit Preview	Mar 2, 2024 0:18am

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)		Mar 2, 2024 0:18am

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Mar 2, 2024 12:28 AM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	34s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	12s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	31s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 1s	15	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 3s	18	0	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	12s	6	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	24s	8	0	1

[cngonzalez]

LGTM!