Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comments): allow ranges to be collapsed #5892

Merged
merged 3 commits into from Mar 4, 2024
Merged

fix(comments): allow ranges to be collapsed #5892

merged 3 commits into from Mar 4, 2024

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Mar 4, 2024 •
edited

Description

This is needed to support including empty blocks within the commented range.

Two first commits here are part of #5891

What to review

Testing

Notes for release

N/A

@skogsmaskin
fix(portable-text-editor): all paths must be checked
3b79ae4 
This optimization was a bit too optimistic.
It's causing issues with some type of selections.
Check every path here.
@skogsmaskin
fix(portable-text-editor): allow uncollapsed ranges
81e740c 
Uncollapsed ranges must be allowed as they may be pointing to empty blocks
@skogsmaskin
fix(comments): allow ranges to be collapsed
b3d8380 
This is needed to support including empty blocks within the commented range
@skogsmaskin skogsmaskin requested a review from a team as a code owner March 4, 2024 13:54
@skogsmaskin skogsmaskin requested review from pedrobonamin and removed request for a team March 4, 2024 13:54
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 4, 2024 1:58pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 1:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 4, 2024 1:58pm

@skogsmaskin skogsmaskin requested review from hermanwikner and removed request for pedrobonamin March 4, 2024 13:54
@skogsmaskin skogsmaskin changed the title Fix/comments allow collapsed fix(comments): allow ranges to be collapsed Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Component Testing Report Updated Mar 4, 2024 2:02 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 30s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 5s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@skogsmaskin skogsmaskin added this pull request to the merge queue Mar 4, 2024
Merged via the queue into next with commit eb5cd50 Mar 4, 2024
40 checks passed
@skogsmaskin skogsmaskin deleted the fix/comments-allow-collapsed branch March 4, 2024 14:33
@Cdaprod Cdaprod mentioned this pull request Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanwikner hermanwikner hermanwikner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skogsmaskin @hermanwikner