feat(codegen): add CLI to generate types given a codegen config #5982

sgulseth · 2024-03-12T14:16:42Z

Description

Adds a CLI command for generating types. This wraps up the interfaces appended in the previous PRs.

What to review

CLI setup
Tracing

Testing

No specific tests added her as it's mainly about wrapping up interfaces from the other PRs.

Notes for release

N/A - no notes needed

sgulseth · 2024-03-12T14:16:50Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite

vercel · 2024-03-12T14:16:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Mar 19, 2024 3:17pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 19, 2024 3:17pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Mar 19, 2024 3:17pm

github-actions · 2024-03-12T14:23:36Z

No changes to documentation

github-actions · 2024-03-12T14:30:10Z

Component Testing Report Updated Mar 19, 2024 3:30 PM (UTC)

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	31s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	13s	3	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	13s	4	2
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	12s	6	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	32s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	59s	15	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 2s	18	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	12s	6	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	20s	9	0

ricokahler

Can you double check if the "workspace:*" dependency is needed?

ricokahler · 2024-03-17T18:38:02Z

packages/sanity/package.json

@@ -202,6 +202,7 @@
    "@sanity/block-tools": "3.34.0",
    "@sanity/cli": "3.34.0",
    "@sanity/client": "^6.15.5",
+    "@sanity/codegen": "workspace:*",


I believe we publish this package.json file so it may be better to match the latest version of this package. I think pnpm/lerna should link/version it automatically. I don't think workspace:* will resolve when publishing this to npm.

I don't think workspace:* will resolve when publishing this to npm.

It will: https://pnpm.io/workspaces#publishing-workspace-packages (it should also be respected by lerna)

Ideally we should use the workspace protocol for all workspace packages.

ricokahler · 2024-03-17T18:48:27Z

packages/sanity/src/_internal/cli/threads/codegenGenerateTypes.ts

+    resolver,
+  })
+
+  for await (const result of queries) {


packages/sanity/tsconfig.lib.json

packages/sanity/tsconfig.json

This was referenced Mar 12, 2024

feat(codegen): add codegen skeleton package #5979

Merged

feat(codegen): add groq finder methods. #5980

Merged

feat(codegen): add typegen methods to codegen package #5981

Merged

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from d0c1813 to 64e2e8d Compare March 12, 2024 14:29

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 0ed028b to e7cff51 Compare March 12, 2024 14:29

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 64e2e8d to 25bda14 Compare March 12, 2024 14:35

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from e7cff51 to 4b1feae Compare March 12, 2024 14:35

vercel bot deployed to Preview – performance-studio March 12, 2024 15:23 View deployment

vercel bot deployed to Preview – test-studio March 12, 2024 15:26 View deployment

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 25bda14 to 40225b3 Compare March 12, 2024 18:14

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 4b1feae to 1d3f323 Compare March 12, 2024 18:14

vercel bot deployed to Preview – performance-studio March 12, 2024 18:21 View deployment

vercel bot deployed to Preview – test-studio March 12, 2024 18:21 View deployment

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 40225b3 to 332270d Compare March 12, 2024 18:43

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 1d3f323 to 4d6e953 Compare March 12, 2024 18:43

vercel bot deployed to Preview – performance-studio March 12, 2024 18:56 View deployment

vercel bot deployed to Preview – test-studio March 12, 2024 18:58 View deployment

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 332270d to 2073606 Compare March 12, 2024 19:32

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 4d6e953 to c33cbc7 Compare March 12, 2024 19:32

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 2073606 to 7447899 Compare March 12, 2024 19:33

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from c33cbc7 to 9fb7222 Compare March 12, 2024 19:33

vercel bot deployed to Preview – performance-studio March 12, 2024 19:41 View deployment

vercel bot deployed to Preview – test-studio March 12, 2024 19:43 View deployment

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 7447899 to f111f34 Compare March 12, 2024 20:36

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 9fb7222 to e9db227 Compare March 12, 2024 20:36

vercel bot deployed to Preview – performance-studio March 12, 2024 20:40 View deployment

ricokahler requested changes Mar 17, 2024

View reviewed changes

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 6405b6f to f92f7b4 Compare March 18, 2024 09:44

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 84eede0 to 4ce884e Compare March 18, 2024 09:44

vercel bot deployed to Preview – performance-studio March 18, 2024 09:51 View deployment

vercel bot deployed to Preview – test-studio March 18, 2024 09:53 View deployment

sgulseth requested a review from ricokahler March 18, 2024 09:59

ricokahler approved these changes Mar 18, 2024

View reviewed changes

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from f92f7b4 to b648872 Compare March 18, 2024 21:46

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 4ce884e to 0a18f59 Compare March 18, 2024 21:46

vercel bot deployed to Preview – performance-studio March 18, 2024 21:54 View deployment

vercel bot deployed to Preview – test-studio March 18, 2024 21:55 View deployment

sgulseth mentioned this pull request Mar 19, 2024

chore: refactor codegen cli group to use typegen cli group #6051

Merged

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from b648872 to 92520dc Compare March 19, 2024 14:07

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 0a18f59 to 037d8b8 Compare March 19, 2024 14:08

vercel bot deployed to Preview – performance-studio March 19, 2024 14:15 View deployment

vercel bot deployed to Preview – test-studio March 19, 2024 14:16 View deployment

sgulseth mentioned this pull request Mar 19, 2024

chore(codegen): bind groq-js to ^1.5.0 #6055

Merged

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 92520dc to 4319333 Compare March 19, 2024 15:01

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 037d8b8 to f1da568 Compare March 19, 2024 15:01

sgulseth force-pushed the 03-12-feat_codegen_add_typegen_methods_to_codegen_package branch from 4319333 to edb7f63 Compare March 19, 2024 15:05

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from f1da568 to 4d9d54c Compare March 19, 2024 15:05

Base automatically changed from 03-12-feat_codegen_add_typegen_methods_to_codegen_package to next March 19, 2024 15:11

feat(codegen): add CLI to generate types given a codegen config

f451330

sgulseth force-pushed the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch from 4d9d54c to f451330 Compare March 19, 2024 15:11

sgulseth added this pull request to the merge queue Mar 19, 2024

Merged via the queue into next with commit 3742b3f Mar 19, 2024
42 of 46 checks passed

sgulseth deleted the 03-12-feat_codegen_add_CLI_to_generate_types_given_a_codegen_config branch March 19, 2024 15:13

vercel bot deployed to Preview – performance-studio March 19, 2024 15:15 View deployment

vercel bot deployed to Preview – test-studio March 19, 2024 15:17 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codegen): add CLI to generate types given a codegen config #5982

feat(codegen): add CLI to generate types given a codegen config #5982

sgulseth commented Mar 12, 2024 •

edited

sgulseth commented Mar 12, 2024 •

edited

vercel bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

ricokahler left a comment

ricokahler Mar 17, 2024

bjoerge Mar 18, 2024 •

edited

ricokahler Mar 17, 2024

feat(codegen): add CLI to generate types given a codegen config #5982

feat(codegen): add CLI to generate types given a codegen config #5982

Conversation

sgulseth commented Mar 12, 2024 • edited

Description

What to review

Testing

Notes for release

sgulseth commented Mar 12, 2024 • edited

vercel bot commented Mar 12, 2024 • edited

github-actions bot commented Mar 12, 2024 • edited

github-actions bot commented Mar 12, 2024 • edited

ricokahler left a comment

Choose a reason for hiding this comment

ricokahler Mar 17, 2024

Choose a reason for hiding this comment

bjoerge Mar 18, 2024 • edited

Choose a reason for hiding this comment

ricokahler Mar 17, 2024

Choose a reason for hiding this comment

sgulseth commented Mar 12, 2024 •

edited

sgulseth commented Mar 12, 2024 •

edited

vercel bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

github-actions bot commented Mar 12, 2024 •

edited

bjoerge Mar 18, 2024 •

edited