Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components] Remove react-text-ellipsis due to perf issues #606

Merged
merged 1 commit into from
Feb 26, 2018
Merged

[components] Remove react-text-ellipsis due to perf issues #606

merged 1 commit into from
Feb 26, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Feb 19, 2018

This had a severe impact on performance in detailed list views, so removing it.

kristofferjs
kristofferjs approved these changes Feb 26, 2018
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we can remove it. But we need to find solution for browsers that dont support text-overflow: ellipsis;

@bjoerge
Copy link
Member Author

bjoerge commented Feb 26, 2018

Which browsers don't support it? Seems pretty well supported if it's this we're talking about: https://caniuse.com/#feat=text-overflow

@bjoerge bjoerge merged commit f520138 into next Feb 26, 2018
@bjoerge bjoerge deleted the remove-react-text-ellipsis branch February 26, 2018 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs kristofferjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjoerge @kristofferjs