Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indicate in metadata that the quickstart option was used in project creation #6065

Merged
merged 7 commits into from Mar 26, 2024

Conversation

svirs
Copy link
Contributor

@svirs svirs commented Mar 19, 2024

Description

Project metadata.template should reflect if the --quickstart flag was used

Testing

Project metadata should show cli-quickstart rather than cli-clean if the --quickstart flag was used for pulling down a project and its schema

@svirs svirs requested a review from a team as a code owner March 19, 2024 18:36
@svirs svirs requested review from cngonzalez and removed request for a team March 19, 2024 18:36
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 26, 2024 4:20pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 4:20pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 4:20pm

Copy link
Contributor

github-actions bot commented Mar 19, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Component Testing Report Updated Mar 26, 2024 4:25 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 40s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 2s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

Copy link
Member

@RostiMelk RostiMelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest looking into how we import/get a template here:

const template = templates[templateName]

If the templateName variable is the name that is being sent to the telemetry service, you may get around this by adding an alias "quickstart" for the "clean" template here:

const templates: Record<string, ProjectTemplate | undefined> = {

LIke so:

const templates: Record<string, ProjectTemplate | undefined> = {
  blog,
  clean,
  'get-started': getStartedTemplate,
  moviedb,
  shopify,
  'shopify-online-storefront': shopifyOnline,
  quickstart: clean // New alias here
}

@svirs svirs marked this pull request as draft March 20, 2024 13:52
Copy link
Contributor

@joneidejohnsen joneidejohnsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested copy changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants