New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: indicate in metadata that the quickstart option was used in project creation #6065
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Mar 26, 2024 4:25 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest looking into how we import/get a template here:
const template = templates[templateName] |
If the templateName
variable is the name that is being sent to the telemetry service, you may get around this by adding an alias "quickstart" for the "clean" template here:
const templates: Record<string, ProjectTemplate | undefined> = { |
LIke so:
const templates: Record<string, ProjectTemplate | undefined> = {
blog,
clean,
'get-started': getStartedTemplate,
moviedb,
shopify,
'shopify-online-storefront': shopifyOnline,
quickstart: clean // New alias here
}
91ef9ff
to
19d87de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested copy changes
Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>
Co-authored-by: Jon Eide Johnsen <joneidejohnsen@gmail.com>
Description
Project metadata.template should reflect if the --quickstart flag was used
Testing
Project metadata should show
cli-quickstart
rather thancli-clean
if the --quickstart flag was used for pulling down a project and its schema