[preview] Emit null as snapshot for missing documents #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
preview-emit-null-for-missing-documents
branch
from
dfe79b7
to
5e566fb
Compare
bjoerge
force-pushed
the
preview-emit-null-for-missing-documents
branch
from
5e566fb
to
90ba9c4
Compare
rexxars
approved these changes
Mar 5, 2018
bjoerge
added a commit
that referenced
this pull request
Mar 5, 2018
* [preview] Emit null values for missing/deleted documents * [preview] Make sure changes are applied to snapshots of same revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves how deleted/missing documents are passed through the preview pipeline, and fixes an error that would sometimes be triggered when a previewed document got deleted.
Previously, any preview observer that declared that they would display some fields on some document (e.g.
fieldX,fieldYfor document with _idabc) would always receive an object with the given fields no matter if the document existed or not. This made it impossible to tell the difference between a document that was deleted and a document that existed but had missing values for these fields.(One consequence of this was that the reference select input for weak references was displaying "Untitled" after the reference got deleted.)
This fixes this problem by passing on
nullas the snapshot for deleted/missing documents.I've also made sure to avoid calling
preview.prepareif the preview snapshot isnull(we may reconsider this, to support overriding the value for Untitled, but that requires some more thoughts I guess)