Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sanity): remove beta and unstable from comments and tasks #6478

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

RitaDias
Copy link
Contributor

Description

Remove the beta and unstable_ from comments and tasks feature.

A request for the change in docs has also been asked.

What to review

Make sure that the comments and tasks are working as expected before the changes.

Testing

Tests should be eventually written, however for now the two following are vital for manual test:
In the sanity.config for the test-studio

  • Tasks: false & unstable_tasks: true (the tasks should not be visible)
  • Comments: false & unstable_comments: true (the comments should not be visible)

Notes for release

Comments and Tasks are now out of beta

@RitaDias RitaDias requested review from a team as code owners April 24, 2024 14:34
@RitaDias RitaDias requested review from cngonzalez and removed request for a team April 24, 2024 14:34
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 30, 2024 6:23am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:23am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 6:23am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 6:23am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Component Testing Report Updated Apr 30, 2024 6:28 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 20s 6 3 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 4s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 23s 9 0 0

Copy link

socket-security bot commented Apr 29, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @RitaDias !

@RitaDias RitaDias added this pull request to the merge queue Apr 30, 2024
Merged via the queue into next with commit f92ba3e Apr 30, 2024
39 checks passed
@RitaDias RitaDias deleted the edx-removing-beta branch April 30, 2024 06:29
cngonzalez pushed a commit that referenced this pull request May 8, 2024
* chore(sanity): remove beta and unstable from comments and tasks

* chore(test-studio): remove unneeded config

* chore(sanity): fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants